WebGPURenderer: improve caches for skinning meshes #32609
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves shader caching issues in WebGPURenderer and its WebGL fallback by ensuring skinned meshes with identical configurations generate identical shader code. Previously, each skinned mesh instance created a unique shader due to non-deterministic uniform buffer naming.
Key changes:
- Modified
ReferenceNodeto generate deterministic names based on properties instead of unique IDs - Updated shader builders to prioritize node names over IDs when generating uniform buffer names
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/nodes/accessors/ReferenceNode.js | Sets deterministic name for ReferenceNode based on properties |
| src/renderers/webgpu/nodes/WGSLNodeBuilder.js | Updates uniform naming logic to use node.name when available |
| src/renderers/webgl-fallback/nodes/GLSLNodeBuilder.js | Updates buffer naming to use node.name when available |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #32527
Description
This PR addresses an issue where
WebGPURenderer(and the WebGL fallback) would generate a unique shader for every skinned mesh instance, preventing shader reuse.Problem
Previously,
ReferenceNodedid not have a name, causing the Node Builders (GLSLNodeBuilderandWGSLNodeBuilder) to generate uniform buffer names based on the node's uniqueid(e.g.,NodeBuffer_1179). This resulted in different shader source code for every skinned mesh, forcing the renderer to recompile shaders unnecessarily.Solution
ReferenceNodeto generate a deterministicnamebased on its properties (e.g.,ref_...).GLSLNodeBuilderandWGSLNodeBuilderto prioritize usingnode.namewhen generating uniform names, falling back toidonly if no name is present.This ensures that skinned meshes with the same configuration generate identical shader code, allowing the renderer to cache and reuse the programs effectively.
Known Limitations
There are still two scenarios where meshes sharing the same material will generate different shaders: